-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Connecting to MKE cluster through MCC Lens extension spams login redirects in the web browser #6966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Note that in this scenario (and in v5.3.0 of the extension), the cluster token is short-lived, so it lasts, I think, ~20 minutes before needing to be renewed. Since the extension uses So it's somewhat easy to get into this scenario, and if Lens is left running on a system over a weekend, it'll just sit there and keep opening browser windows all weekend long. So you come back, and you have potentially hundreds of windows open... I, too, believe Lens should have a de-escalation algorithm to exponentially taper off to no longer trying to auto-connect. |
Now cluster access tokens can optionally be generated as offline (i.e. long-lived) tokens on a per-mgmt cluster basis. This works around (well, _delays_ for a long time) lensapp/lens#6966
Now cluster access tokens can optionally be generated as offline (i.e. long-lived) tokens on a per-mgmt cluster basis. This works around (well, _delays_ for a long time) lensapp/lens#6966 NOTE: Also has a partial implementation of the new 'trust host' feature that was started at the same time as 'offline access', but which is not currently exposed to the user.
Now cluster access tokens can optionally be generated as offline (i.e. long-lived) tokens on a per-mgmt cluster basis. This works around (well, _delays_ for a long time) lensapp/lens#6966 NOTE: Also has a partial implementation of the new 'trust host' feature that was started at the same time as 'offline access', but which is not currently exposed to the user.
Now cluster access tokens can optionally be generated as offline (i.e. long-lived) tokens on a per-mgmt cluster basis. This works around (well, _delays_ for a long time) lensapp/lens#6966 NOTE: Also has a partial implementation of the new 'trust host' feature that was started at the same time as 'offline access', but which is not currently exposed to the user.
Describe the bug
When connecting to MKE clusters through the MCC Lens extension, a redirect to MCC UI is realized for login purposes (through SSO).
However, when the cluster gets disconnected, Lens tries to reconnect indefinitely, which has as a result that the browser is spammed with MCC login redirects.
To Reproduce
Steps to reproduce the behavior:
Expected behavior
I would expect Lens to gradually increase the connect retry period and at some point to stop trying to reconnect to the cluster after a given number of retries.
Screenshots
Environment (please complete the following information):
Logs:
Kubeconfig:
Additional context
The text was updated successfully, but these errors were encountered: