Unify vi-mode visual state with lem buffer marks #1817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomaneo
force-pushed
the
mark-visual
branch
3 times, most recently
from
7b61ff8 to
47bdcda
Compare
Use buffer mark instead of internal veriable to handle visual mode start point tracking. Any core function which sets buffer mark can thus enable visual mode which means that also selecting area with mouse is compatible with vi mode. Make vi states to be buffer specific, not global. This fixes several minor glitches and annoyances when switching between windows and buffers
|
Rebased to current main |
|
I would also like to see this merged in, since it would help in porting other modal text editing styles, like Kakoune |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modified the visual states in vi mode to use lem buffer mark as starting point and initiator of visual mode regions. To support synchronisation some small additions to core lem implementation was needed, mainly hooks for enabling and disabling the buffer mark.
This allows activating visual mode from any of the "mark-xxx" commands available on emacs mode side, including mouse operations.
Vi states are now buffer specific, not global. This fixes several small glitches and annoyances when switching between windows and buffers
Closes #1590