Improve oauth redirect #303
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background & Aim
I have migrated my existing instance from docker to podman and forget to set the
RUSTDESK_API_RUSTAPI_API_SERVER
. It still works fine until I tried to login via oauth and it brings me to127.0.0.1:21114/xxxxx
.I think, accroading to web standers, the host part can be omited when redirect amount same host. So, my initial idead is just remove every host parts from the redirect url. However, I find it can be further improved when reading relavent codes.
Changes & Reasons
RedirectURL
from oauth config. As they are only checked, for security reasons, by the oauth provider for security reasons. Since the pervious change has already relaxed the needing of this field when generating responses, removing it can improve the overall robustness -- no need to chage a same setting multiple times at different configs.