Make Manual Question Selection alert non-sticky on scroll #13331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
APP: Coach
Build Artifacts
|
AlexVelezLl
reviewed
Apr 16, 2025
|
|
||
| .alert.warning { | ||
| position: sticky; | ||
| z-index: 1; |
There was a problem hiding this comment.
I know this was not introduced by this PR, but since we changed the cards to use KCard, cards thumbnails now have a z-index: 1, and this warning is appearing behind these thumbnails. Could you increase it to two now that we are modifying this part of the code? 😅
Although I dont know if this is something we should fix in 0.18.0 cc: @rtibbles.
There was a problem hiding this comment.
Thanks for pointing this out! Since it wouldn't introduce any styling conflicts in this current PR, I went ahead and updated the z-index to 2.
rtibbles
modified the milestones:
Kolibri 0.18: Planned Patch 1,
Kolibri 0.18: General maintenance
rtibbles
added
P0 - critical
…kolibri into banner-no-sticky
LianaHarris360
force-pushed
the
banner-no-sticky
branch
from
3d421f6 to
99ab1eb
Compare
|
Manual question selection banner is sticky no more! 💥
Confirmed also when browsing bookmarks 👍🏽 |
radinamatic
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request divides the class
alert-warninginto two classes to ensure that the manual question selection banner is not sticky, while the banner for the selected maximum content remains sticky when scrolling in theSidePanelModal.Before:
Before.mov
After:
After.mov
References
Fixes #13299
Reviewer guidance