Add defensive programming checks for progress setting and calculation #13328
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
DEV: backend
Build Artifacts
|
Comment on lines
+257
to
+259
| logger.warning( | ||
| f"Tried to set invalid progress values on job {self.job_id} for task {self.func} with progress: {progress} and total_progress {total_progress}" | ||
| ) |
There was a problem hiding this comment.
Would it be helpful here to raise a ValueError here? I can see myself missing the warning in the logs if I were coming at this while debugging in progress updating on the front-end or something. Not a blocking comment - just a thought.
There was a problem hiding this comment.
My reason for only logging is that given we have seen this in the wild (as per the issue) I don't want to cause existing jobs to fail just because of a progress tracking error.
|
Variety of import/update/delete scenarios where performed with few resources and complete channels on both Ubuntu and Windows, no issues or regressions observed in the UI, task manager page or the console. |
radinamatic
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #13321
Reviewer guidance
Do a quick smoke test of content import for a new channel to ensure against regressions in task calculation