Skip to content

Add in submit quiz button for non-large screen sizes. #12412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 3, 2024

Conversation

rtibbles
Copy link
Member

@rtibbles rtibbles commented Jul 3, 2024

Summary

  • Adds the submit button back for non-large screen sizes
  • Deliberately does not include the number of questions answered as it takes up too much space
  • Fixes unreported bug in section change handling on tablet and phone screen sizes
  • Updates ExamPage KSelects to be annotated with answer state, parallel to the accordion display.

References

Fixes #12410

Reviewer guidance

View on a tablet or phone screen dimensions.
Ensure that the submit quiz button shows up as a flat button, then a raised one once all questions are answered.
Ensure that it comes last in the tab order after the previous/next buttons
Ensure that changing the section via the top KSelect works.

Mobile
Screenshot from 2024-07-03 12-04-36

Tablet

Screenshot from 2024-07-03 12-04-58

Desktop
Screenshot from 2024-07-03 12-05-18

(screenshots taken prior to addition of answer state indicators in KSelect)

Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

@rtibbles rtibbles requested a review from marcellamaki July 3, 2024 20:25
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Jul 3, 2024
@rtibbles rtibbles added TODO: needs review Waiting for review and removed APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Jul 3, 2024
@github-actions github-actions bot added APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend labels Jul 3, 2024
Copy link
Member

@marcellamaki marcellamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - all manual QA checks out including indicator

@marcellamaki marcellamaki merged commit 00d9db7 into learningequality:develop Jul 3, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Learn Re: Learn App (content, quizzes, lessons, etc.) DEV: frontend TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Submit button missing in quizzes on Android
2 participants