EQM: Validation improvements #12281
EQM: Validation improvements #12281
Conversation
github-actions
bot
added
APP: Coach
Build Artifacts
|
| @@ -63,6 +65,7 @@ export default function useQuizCreation() { | |||
| * @throws {TypeError} if section is not a valid QuizSection | |||
| **/ | |||
| function updateSection({ section_id, ...updates }) { | |||
| set(quizHasChanged, true); | |||
There was a problem hiding this comment.
is it ever possible for updateSection to be called when there are not actually any changes?
There was a problem hiding this comment.
I think probably the more likely case is for someone to change something, then change it back - in which case this would be set to true, and there not actually be any changes. I think that edge case is worth having for the sake of simplicity (rather than deep diff checking).
| @@ -53,6 +53,19 @@ | |||
|
|
|||
| </KPageContainer> | |||
|
|
|||
| <KModal | |||
| v-if="goingTo" | |||
There was a problem hiding this comment.
this is absolutely a nit but could you change this to something that makes it a bit clearer about what this is just from reading the variable name? i.e. a route object, a boolean, etc.
| @@ -318,6 +317,9 @@ | |||
| handleSubmitTitleFailure() { | |||
| this.formIsSubmitted = false; | |||
| this.showTitleError = true; | |||
| this.$refs.titleField.focus(); | |||
| // Scroll to the title field in case focus() didn't do that immediately | |||
| this.$refs.titleField.$el.scrollIntoView({ behavior: 'smooth' }); | |||
There was a problem hiding this comment.
non-blocking: my only suggestion for here is that maybe we just scroll to the top of the page, since the app bar is covering the field with the default scroll behavior?
scroll-into-view.mp4
nucleogenesis
force-pushed
the
fix--make-eqm-validations-good
branch
from
e1b86a6 to
934b947
Compare
this is reminder basically that we should always use displaySectionTitle -- could possibly be improved by making a computed activeSectionTitle computed property in usequizcreation?
nucleogenesis
force-pushed
the
fix--make-eqm-validations-good
branch
from
934b947 to
9c36032
Compare
Summary
trim()section_title all about so we're always testing "is this unique" correctlyI think that "fix the snackbars" can be done in a follow-up -- there is no change to strings, but just a need to use
displaySectionTitlethroughout.References
Closes #12262
Reviewer guidance