-
Notifications
You must be signed in to change notification settings - Fork 805
Remove Python 2.7 support #11654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Remove Python 2.7 support #11654
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bjester
reviewed
Dec 15, 2023
f95e259
to
5508a80
Compare
Build Artifacts
|
Setup whl build for Python 3.6.
Upgrade pex for Python 3.11 compatibility.
Cleanup Python 2.7 in browser deprecation warning.
5508a80
to
fe0efa3
Compare
bjester
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A freshly groomed Kolibri!
This was referenced Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
APP: Coach
Re: Coach App (lessons, quizzes, groups, reports, etc.)
APP: Device
Re: Device App (content import/export, facility-syncing, user permissions, etc.)
APP: Facility
Re: Facility App (user/class management, facility settings, csv import/export, etc.)
APP: Learn
Re: Learn App (content, quizzes, lessons, etc.)
APP: Setup Wizard
Re: Setup Wizard (facility import, superuser creation, settings, etc.)
APP: User
Re: User app (sign-in, sign-up, user profile, etc.)
DEV: backend
Python, databases, networking, filesystem...
DEV: dev-ops
Continuous integration & deployment
DEV: frontend
DEV: renderers
HTML5 apps, videos, exercises, etc.
DEV: tools
Internal tooling for development
SIZE: medium
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References
Fixes #1963
Fixes #10363
Fixes #10484
Reviewer guidance
Do all tests still pass? Do the WHL and PEX file still work?
For review, I would recommend going commit by commit - each one handles a different logical section of the removal. The futures imports removals are rote, but widespread, the six removals a bit more constrained but hit a lot of files.
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)