feat: send $/lean/fileProgress notification
#510
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vtec234
reviewed
Jun 4, 2021
Vtec234
requested changes
Jun 4, 2021
There was a problem hiding this comment.
Should we also send a progress update after compiling the header? This would be a Oh well, I guess publishProgressAtPos after FileWorker.lean:208. The headerSnap should have the right endPos.nextCmdSnap will do it, so this was a useless suggestion.
Looks good, thanks!
Vtec234
approved these changes
Jun 4, 2021
|
Guess I'll have to think about what to do in Emacs now... 😬 |
ChrisHughes24
pushed a commit
to ChrisHughes24/lean4
that referenced
this pull request
Dec 2, 2022
The support for `Max` and `Min` classes is still somewhat minimal (no pun intended). The relevant files still require proper porting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #503.
The vscode implemention is already deployed.