Skip to content

macOS support broken since Flutter 3.16.0 #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jagmit opened this issue Nov 27, 2023 · 0 comments · Fixed by #16
Closed

macOS support broken since Flutter 3.16.0 #15

jagmit opened this issue Nov 27, 2023 · 0 comments · Fixed by #16

Comments

@jagmit
Copy link
Contributor

jagmit commented Nov 27, 2023

The handler for URL events does not get called anymore by the OS when building and using this plugin with Flutter 3.16.0.
I could trace down the origin of this to flutter/engine#44587 and flutter/engine#44689. I'm not an expert on macOS but my assumption is that macOS stops emitting get URL events via NSAppleEventManager once an application implements the openURLs method of the NSApplicationDelegate protocol and marks those events as handled there.

The second change in the Flutter engine seems to do that.

I have identified two possible fixes for this:

Personally I prefer the latter since it seems to be the new intended way by Flutter to get notified about these type of events. Additionally this approach opens up the possibility to improve interoperability of this plugin with others that also rely on receiving URL events. This could be done by extending this plugin's API to allow to configure which URLs should and which should not be marked as consumed by this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant