Skip to content

Add leancode markup #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 63 commits into from
Mar 7, 2024
Merged

Add leancode markup #249

merged 63 commits into from
Mar 7, 2024

Conversation

pdenert
Copy link
Contributor

@pdenert pdenert commented Mar 7, 2024

No description provided.

Jan Wieczorek and others added 30 commits December 7, 2022 11:39
Init commit: add lexer, parser and tests
4ed0795
Update README
80245b6
@shilangyu
Rename markdown to markup
83f5be8
@shilangyu
Add leancode_lints
af958b5
@shilangyu
Refactor lexer to use generic tokens
15ea265
@shilangyu
Add basic benchmarking
cf584bd
@shilangyu
Refactor parser
aca1734
@shilangyu
Update readme to reflect newest changes
fc37ad8
@shilangyu
Add MarkupTag to parsing
0dacb55
@shilangyu
Add parameter parsing
27efada
@shilangyu
Change held tag information
9e1c6ed
@shilangyu
Preserve tag order
ebc455e
@shilangyu
Add basic Flutter rendering
a58baff
@shilangyu
Refresh code for dart 3
dd93fa9
@pdenert
add example app
7835364 
add a description of use to the readme
add basic tags to DefaultMarkupStyle
@pdenert
remove widget_test from example
4250f5c 
remove what's done section from readme
@pdenert
Merge pull request #2 from leancodepl/prepare-for-simple-usage
0e76467 
Prepare for simple usage
@pdenert
upgrade flutter to 3.13.0
4ed91ff 
update pub dependencies
@pdenert
add custom_lint
b2fa6b7
@pdenert
Merge pull request #4 from leancodepl/update-dependencies
ab29e12 
Update dependencies
@pdenert
Add tag-factory
a06221b
@pdenert
Add example with tag-factory with launchUrl
eeef138
@pdenert
Make tagFactories not required in DefaultMarkupStyle
bf6ac52
@pdenert
Clean markup text
ab9f786
@pdenert
Update readme and comments
cb099b2
@pdenert
Update macos files
fee38ce
@pdenert
Change example app and example in readme
2f3958f
@pdenert
Return InlineSpan instead of WidgetSpan from tag factory
76ce6fa
@pdenert
Rename factory typedef to MarkupTagSpanFactory
696b102
@pdenert
Rename tags to tagStyles
096089f
pdenert and others added 18 commits February 26, 2024 21:36
@pdenert
Add show invalid tokens example in main
268e33d
@pdenert
Remove tests for exceptions
014a3b0
@pdenert
Add logging optional method
cf8032e
@pdenert
Merge branch 'main' of https://github.com/leancodepl/tag-parser into …
0c5e03d 
…ignore-alone-and-wrong-tags
@pdenert
Fix typo
541f250
@pdenert
Rever deleted code from parseTokens
5c3310c
@pdenert @shilangyu
Change cleanUpTokens description
4c75b2a 
Co-authored-by: Marcin Wojnarowski <[email protected]>
@pdenert
Use tokens.indexed
68677ca
@pdenert
Use double slash in comments
56a0d70
@pdenert
Rename test group
6a68781
@pdenert
Use logging package
1635f87
@pdenert
Optimize cleanUpTokens
af7a37e
@pdenert @shilangyu
Change comment for logger
7dd511d 
Co-authored-by: Marcin Wojnarowski <[email protected]>
@pdenert
Revert parser exception tests
5fdeeb2
@pdenert
Merge pull request #7 from leancodepl/ignore-alone-and-wrong-tags
48fea70 
Cleanup tokens based on ParsingAloneTagTactic
@pdenert
Change readmes and examples to Leancode markup name
5d5f0d3
@pdenert
Merge pull request #8 from leancodepl/remove-tag-parser-from-docs
e4f9297 
Change readme's and examples to Leancode markup name
@pdenert
Add 'packages/leancode_markup/' from commit 'e4f9297e23a46f3eebb95a29…
78a15e5 
…243723dafb24cda1'

git-subtree-dir: packages/leancode_markup
git-subtree-mainline: c1d8d4b
git-subtree-split: e4f9297
@pdenert pdenert added the enhancement New feature or request label Mar 7, 2024
@pdenert pdenert self-assigned this Mar 7, 2024
shilangyu
shilangyu approved these changes Mar 7, 2024
View reviewed changes
Copy link
Contributor

@shilangyu shilangyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR but the commits look correctly ported

@Albert221
Copy link
Member

Do we need all these platforms in example/?

@pdenert
Copy link
Contributor Author

pdenert commented Mar 7, 2024

Do we need all these platforms in example/?

We support all of them, so why not?

@Albert221 Albert221 mentioned this pull request Mar 7, 2024
Open
@pdenert pdenert merged commit 6f3e29f into master Mar 7, 2024
@pdenert pdenert deleted the add-leancode-markup branch March 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Albert221 Albert221 Albert221 left review comments

@shilangyu shilangyu shilangyu approved these changes

@RobertOdrowaz RobertOdrowaz Awaiting requested review from RobertOdrowaz

Assignees

@pdenert pdenert

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pdenert @Albert221 @shilangyu