Skip to content

Fix constants ignoring ExcludeFromContractsGenerationAttribute #169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: analyzer-issues
Choose a base branch
from

Conversation

Saancreed
Copy link
Member

@Komoszek This one is dedicated for you.

Fixes #164.

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (analyzer-issues@ec3e2a9). Learn more about missing BASE report.

Additional details and impacted files
@@                Coverage Diff                 @@
##             analyzer-issues     #169   +/-   ##
==================================================
  Coverage                   ?   82.11%           
==================================================
  Files                      ?       34           
  Lines                      ?      995           
  Branches                   ?      117           
==================================================
  Hits                       ?      817           
  Misses                     ?      133           
  Partials                   ?       45           
Flag Coverage Δ
net9.0 82.11% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@jakubfijalkowski jakubfijalkowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+ changelog entry pls

@Saancreed
Copy link
Member Author

  • changelog entry pls

I'm holding off with that until #167 is merged to have a general idea about what will get into 4.0.0 release.

Copy link
Contributor

@Komoszek Komoszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💋

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants