Skip to content

Add error code uniqueness guideline #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add error code uniqueness guideline #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions docs/guidelines.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,10 @@ This is currently not blocked, but might be in the future.

Unless it is impossible to model as a two separate actions or the resulting API would be awkward.

### Prefer globally unique error codes in nested DTOs

2 DTOs can be used by 1 command in the future. In that case those DTOs will have to have unique error codes. Changing error codes values is a breaking change. To omit breaking change, it is better to have globally unique error codes in nested DTOs.

## DTOs & Enums

### Postfix DTOs & enums with `DTO`
Expand Down
Loading