fix(field-suggestions): Fix block-field-suggestions rule throwing Bod… #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y already Read error when response body does not contain expected json payload
ldebruijn
added a commit
that referenced
this pull request
Jan 23, 2024
#19) Fix bug on Block Field suggestions rule. We found that the block field suggestion rule broke when the response body did not contain the valid JSON (i.e. when proxying GraphiQL). This MR makes sure to read the response body as plain bytes, try to determine whether it can and should be modified and if that fails, set the body back to the original bytes so that it can be read again later. Co-authored-by: ldebruijn <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix bug on Block Field suggestions rule.
We found that the block field suggestion rule broke when the response body did not contain the valid JSON (i.e. when proxying GraphiQL).
This MR makes sure to read the response body as plain bytes, try to determine whether it can and should be modified and if that fails, set the body back to the original bytes so that it can be read again later.