tests/codegen/casm.c: Move to casm.i to avoid calling the preprocessor #4662
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We only need this to be a .c to preprocess the FWIW, this test originates from https://github.com/ldc-developers/ldc/blob/master/tests/dmd/fail_compilation/fail24389.c. |
Don't call the C preprocessor as it may fail in a cross-compilation environment. Drop the `-mtriple` argument and let the test run on all platforms. Signed-off-by: Andrei Horodniceanu <[email protected]>
the-horo
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test may fail on x86 because, when calling the C preprocessor, ldc will append a -m argument based on the target. If the target is x86_64 and the host is x86 the C compiler may fail with:
An easy solution for this is to specify i386 instead of x86_64 in the target triple.
I'm not 100% sure if the
-mtripleargument can be just dropped so I went ahead with a more conservative fix.