Skip to content

Fix image assembly load by providing the full name #440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2021

Conversation

sharwell
Copy link
Collaborator

@sharwell sharwell commented Jul 23, 2021

This approach works, but will require manual updates to the version number whenever version.json changes (e.g. 30ea1d3).

Fixes #383

@sharwell sharwell marked this pull request as ready for review July 23, 2021 19:22
Copy link
Owner

@laurentkempe laurentkempe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after some tests with two instances of VS 2019 Exp the icons appear on both! 👍🏼 @sharwell

@laurentkempe laurentkempe merged commit 03c5d40 into laurentkempe:master Aug 4, 2021
@sharwell sharwell deleted the resources branch August 10, 2021 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Icons are missing from the popup window
3 participants