Skip to content

Fixes InvalidAuthenticationToken for OneDrive #3674

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Fixes InvalidAuthenticationToken for OneDrive #3674

merged 1 commit into from
Aug 28, 2020

Conversation

jonath92
Copy link
Contributor

@jonath92 jonath92 commented Aug 27, 2020

Bug reported in the forum. The Bug has been introduced in the pr for onedrive for business. The Bug happened because of missing error handling when requesting the account properties. Sorry for that :-(. It should work now.

The Bug can be reproduced by the following:

  1. Set the value for sync.3.context in the "settings" table in the sqlite database to ""
  2. Change the access token in the JSON text for sync.3.auth in the "settings" table so that the token is invalid (just change one character)
  3. start joplin and sync to onedrive

@laurent22 laurent22 merged commit 39bffd2 into laurent22:dev Aug 28, 2020
@laurent22
Copy link
Owner

Thanks for the quick fix! I'm going to merge it now and release so that they can confirm in the forum if it works for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants