Skip to content

Desktop: Fixed KaTeX font issue in exported PDF #3089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 20, 2020

Conversation

kowalskidev
Copy link
Contributor

@kowalskidev kowalskidev commented Apr 19, 2020

Fixes #3078

When we export a note InteropService() render a note in HTML file in temp directory then using that HTML file PDF get exported, Now I figured out that HTML file requires a katex.css which is already exported by plugin and katex.css requires the fonts included in fonts directory which is not exported by plugin so we need to export the fonts directory also along with katex.css now I added the fonts in katex.js so they also will be exported. Now everything working fine!

@PackElend Can you label me please? Thank you!

@tessus tessus added the desktop All desktop platforms label Apr 19, 2020
Copy link
Collaborator

@tessus tessus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@laurent22
Copy link
Owner

Great, thanks for the fix!

@laurent22 laurent22 merged commit c65ee4a into laurent22:master Apr 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop All desktop platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Math font in exported PDF is different from that in the preview
4 participants