Desktop: fix sub pixel rendering #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Did you test in dark and light theme? Does it change something? |
|
Yes, I didn't see any visible changes, other than improved font rendering. It seems like everything else already has an explicit background colour (which makes sense, given that the dark theme already looks quite different from the light one :-)). |
|
Looks good then, thanks! |
This was referenced Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change improves font rendering for the electron desktop client.
For subpixel rendering to work electron requires the background to be non-transparent.
This has to be set as an option for the BrowserWindow, see https://github.com/electron/electron/pull/16459/files