Desktop: Fixes #9588: Rich Text Editor: Fix keyboard and plugin-opened context menus sometimes not displayed or have incorrect content #12076
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This pull request changes how context menu events are handled in the Rich Text Editor. Rather than determining the target element using Electron
context-menu
events, this is done with browsercontextmenu
events.This change was originally intended to fix #12058. Unfortunately, it doesn't do so. However, it does resolve two similar issues:
contextmenu
event. This does not trigger the Electroncontext-menu
event. As a result, previously, no context menu was displayed. (Rich text editor: Mermaid diagram download button doesn't work #9588).Testing
Testing plan (Fedora 41 Linux):