drop python<=3.7 support #71
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to https://endoflife.date/python python 3.7 support has been EOSed 27 Jun 2023. Pass all code over `pyupgrade --py38`. Signed-off-by: Tomasz Kłoczko <[email protected]>
Signed-off-by: Tomasz Kłoczko <[email protected]>
|
I know, it's crazy, but I don't want to drop support for old versions of Python in the '1.2.x' version. |
|
OK I understand .. please let me know if you will make decision about this PR. |
laurent-laporte-pro
requested changes
Nov 15, 2024
There was a problem hiding this comment.
Can you change string_types to str?
You should also update the project metadata. In particular, older versions of Python should be removed from the classifiers section of the setup.py file.
Of course, you'll also need to update the documentation: a good rereading is necessary. In particular, there's the introductory sentence in the `installation.rst' document. I'm sure there are other places to correct...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to https://endoflife.date/python python 3.7 support has been EOSed 27 Jun 2023.
Pass all code over
pyupgrade --py38.