Skip to content

Single tf noise #1008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 3, 2025
Merged

Single tf noise #1008

merged 2 commits into from
Feb 3, 2025

Conversation

brunofavs
Copy link
Collaborator

Hey, this PR comes as a request from #1006.

It is a sub-PR of #989, containing a smaller set of features.

Features :

  • Add noise to a specific transformation.
  • Overhaul of noise adding mechanism ( Refactor only, functionality remains the same).
  • Rotation noise now uses uniform distribution instead of choice.
    v = np.random.uniform(-1.0, 1.0, 3)
    v = v / np.linalg.norm(v)

This was the least amount of features I could add to implement specific transformation noise. There were implemented only the strictly necessary dependencies.

I tested with Softbot and it worked well. I used the `-ctgt' flag to ensure the noise added was correct.

A MWE example to test the feature would be something like this. Any softbot dataset shall work as long as the most recent config.yml is used. The one in atom examples works.

rosrun atom_calibration calibrate \                                                                                                         
-json ${Dataset_of_Choice} \                                                                                                                   
-v  -ctgt \                                                                                                                                    
-nig 0.1 0.1 \                                                                                                                           
-ntfv 0.1 0.1 \                                                                                                                                
-ntfl "world:base_footprint"                                                                                                                  

Regarding the overhaul.
Mainly, now all noise is computed in one function that is called by the
other functions to apply noise to the initial guess, sensors, additional
TFs...
@miguelriemoliveira
Copy link
Member

Hey @brunofavs ,

thanks for the PR.

I inspected it and it seems fine. Even though you tried to compartmentalize, still it affects 9 files!

I cannot make sure it has no side effects, but let's accept it and then be on the lookout for those.

@miguelriemoliveira miguelriemoliveira merged commit 29d3da1 into noetic-devel Feb 3, 2025
@brunofavs
Copy link
Collaborator Author

Many of those 9 files are minor things though. 2 of them are just due to the renaming of a function, 2 are xacros that I actually uploaded on accident. If something were to break, I would bet it would have to do with dataset_io.py.

But yeah, lets be on the lookout for unexpected things, better safe than sorry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants