Skip to content

Fix DB_DATABASE replacement in phpunit.xml #783

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025
Merged

Conversation

choowx
Copy link
Contributor

@choowx choowx commented Apr 11, 2025

Since this commit in the skeleton, the Sail installation doesn't work correctly for updating the DB_DATABASE value in phpunit.xml on new Laravel applications.

This PR updates the search pattern to match both commented and uncommented lines, ensuring compatibility with projects created both before and after this update.

@taylorotwell taylorotwell merged commit b52b5e8 into laravel:1.x Apr 11, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants