Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VESSL AI OpenAI API-compatible model provider and LLM model #9474

Merged

Conversation

larcane97
Copy link
Contributor

Checklist:

Important

Please review the checklist below before submitting your pull request.

  • Please open an issue before creating a PR or link to an existing issue
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

Description

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue. Close issue syntax: Fixes #<issue number>, see documentation for more details.

  • add new vessl ai model provider
  • add open api url postfix in OAIAPICompatLargeLanguageModel

🔔 Not Yet added yaml configuration. It'll be added within a week.

  • after adding, this comment will be deleted

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update, included: Dify Document
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement
  • Dependency upgrade

Testing Instructions

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • test_validate_credentials
  • test_invoke_model
  • test_invoke_stream_model
  • test_get_num_tokens

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ⚙️ feat:model-runtime 💪 enhancement New feature or request labels Oct 18, 2024
@YIXIAO0 YIXIAO0 requested a review from Yeuoly October 18, 2024 03:39
@larcane97 larcane97 requested a review from Yeuoly October 18, 2024 09:19
@Yeuoly
Copy link
Collaborator

Yeuoly commented Oct 18, 2024

It seems that you forgot to add the yaml file? This is necessary, otherwise frontend will not be able to render the icon and display the model name and other information as expected.

@crazywoola crazywoola marked this pull request as draft October 18, 2024 12:12
@larcane97
Copy link
Contributor Author

@Yeuoly
yes right as I mentioned above, the yaml file isn't applied yet.
I'll apply yaml file as soon as possible
I just wanted to ask you code level review !
once applying yaml file, I'll notify you again. thank you :)

@larcane97 larcane97 marked this pull request as ready for review October 21, 2024 06:46
@larcane97
Copy link
Contributor Author

@Yeuoly
Hello Yeouly, i added yaml file and assets
then i think all i have to add is done, so can you review this pr?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 1, 2024
@YIXIAO0 YIXIAO0 removed the request for review from Yeuoly November 1, 2024 05:08
@YIXIAO0 YIXIAO0 requested review from Yeuoly and removed request for Yeuoly November 1, 2024 05:10
@crazywoola crazywoola merged commit 8d5456b into langgenius:main Nov 1, 2024
6 checks passed
AlwaysBluer pushed a commit to AlwaysBluer/dify that referenced this pull request Nov 2, 2024
…m-vdb

* 'lindorm-vdb' of github.com:AlwaysBluer/dify: (39 commits)
  Feat : add LLM model indicator in prompt generator (langgenius#10187)
  chore: enable vision support for models in OpenRouter that should have supported vision (langgenius#10191)
  chore : code generator preview hint (langgenius#10188)
  fix: webapp upload file (langgenius#10195)
  fix(api): replace current_user with end_user in file upload (langgenius#10194)
  feat(document_extractor): integrate unstructured API for PPTX extraction (langgenius#10180)
  fix(tools): suppress RuntimeWarnings in podcast audio generator (langgenius#10182)
  [fix] fix the bug that modify document name not effective (langgenius#10154)
  fix(workflow model): ensure consistent timestamp updating (langgenius#10172)
  fix: Cannot find declaration to go to CLEAN_DAY_SETTING (langgenius#10157)
  feat: add gpustack model provider (langgenius#10158)
  refactor(tools): Avoid warnings. (langgenius#10161)
  refactor(migration/model): update column types for workflow schema (langgenius#10160)
  Feat/add-remote-file-upload-api (langgenius#9906)
  fix: upload remote image preview (langgenius#9952)
  clean un-allowed special charters when doing indexing estimate (langgenius#10153)
  refactor(service): handle unsupported DSL version with warning (langgenius#10151)
  Add VESSL AI OpenAI API-compatible model provider and LLM model (langgenius#9474)
  feat: synchronize input/output variables in the panel with generated code by the code generator (langgenius#10150)
  Refined README for better reading experience. (langgenius#10143)
  ...
iamjoel pushed a commit that referenced this pull request Nov 7, 2024
idonotknow pushed a commit to AceDataCloud/Dify that referenced this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request ⚙️ feat:model-runtime lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants