Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: metadata on documents are orphaned #16307

Merged
merged 4 commits into from
Mar 20, 2025

Conversation

JohnJyong
Copy link
Collaborator

Summary

  1. add old metadata migrate command
  2. remove old doc-metadata logic in service api

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.
fix #16256

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Mar 20, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 20, 2025
@crazywoola crazywoola merged commit 2c9af71 into main Mar 20, 2025
10 checks passed
@crazywoola crazywoola deleted the fix/create-document-by-api-with-metadata branch March 20, 2025 06:33
@laipz8200 laipz8200 changed the title Fix/create document by api with metadata fix: metadata on documents are orphaned Mar 20, 2025
@DavideDelbianco
Copy link

From the source code of this PR it seems to me that there's no filtering logic for the built-in metadata keys
image

Those keys were/are present in the doc_metadata field
image

And the UI seems to throw an error when you attempt to add a custom metadata key that's already part of the built-in ones
Animazione

@hsiong hsiong mentioned this pull request Mar 23, 2025
5 tasks
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Knowledge] Metadata on documents are orphaned with 1.1.0
4 participants