Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change recreate_collection function to create_collection #16212

Merged
merged 1 commit into from
Mar 19, 2025
Merged

feat: change recreate_collection function to create_collection #16212

merged 1 commit into from
Mar 19, 2025

Conversation

JohnJyong
Copy link
Collaborator

@JohnJyong JohnJyong commented Mar 19, 2025 •
edited by laipz8200
Loading

Summary

change recreate_collection function to create_collection

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. labels Mar 19, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2025
@crazywoola crazywoola merged commit c3c957b into main Mar 19, 2025
11 checks passed
@crazywoola crazywoola deleted the fix/tidb-recreate-collection-issue branch March 19, 2025 09:13
@laipz8200 laipz8200 changed the title change recreate_collection function to create_collection feat: change recreate_collection function to create_collection Mar 20, 2025
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
@JohnJyong @parambharat
change recreate_collection function to create_collection (langgenius#…
ed4ab50 
…16212)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
👻 feat:rag Embedding related issue, like qdrant, weaviate, milvus, vector database. lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JohnJyong @crazywoola