Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change public functions to protected in PromptTransform #16143

Merged
merged 2 commits into from
Mar 19, 2025

Conversation

hyongtao-db
Copy link
Contributor

Summary

  • Change public functions to protected functions
  • Remove useless unit test codes

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Mar 18, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 19, 2025
@crazywoola crazywoola merged commit d339403 into langgenius:main Mar 19, 2025
6 checks passed
@laipz8200 laipz8200 changed the title Chore: optimize the code of PromptTransform refactor: change public functions to protected in PromptTransform Mar 20, 2025
@hyongtao-db hyongtao-db deleted the dev branch March 25, 2025 01:55
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants