Skip to content

fix: remove unnecessary modal #15493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 2 additions & 27 deletions web/app/components/app/app-publisher/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,6 @@ import WorkflowToolConfigureButton from '@/app/components/tools/workflow-tool/co
import type { InputVar } from '@/app/components/workflow/types'
import { appDefaultIconBackground } from '@/config'
import type { PublishWorkflowParams } from '@/types/workflow'
import VersionInfoModal from './version-info-modal'

export type AppPublisherProps = {
disabled?: boolean
Expand Down Expand Up @@ -73,7 +72,6 @@ const AppPublisher = ({
const { t } = useTranslation()
const [published, setPublished] = useState(false)
const [open, setOpen] = useState(false)
const [publishModalOpen, setPublishModalOpen] = useState(false)
const appDetail = useAppStore(state => state.appDetail)
const { app_base_url: appBaseURL = '', access_token: accessToken = '' } = appDetail?.site ?? {}
const appMode = (appDetail?.mode !== 'completion' && appDetail?.mode !== 'workflow') ? 'chat' : appDetail.mode
Expand Down Expand Up @@ -133,27 +131,11 @@ const AppPublisher = ({

const [embeddingModalOpen, setEmbeddingModalOpen] = useState(false)

const openPublishModal = useCallback(() => {
setOpen(false)
setPublishModalOpen(true)
}, [])

const closePublishModal = useCallback(() => {
setPublishModalOpen(false)
}, [])

const onClickPublishBtn = useCallback(() => {
if (isChatApp)
handlePublish()
else
openPublishModal()
}, [isChatApp, handlePublish, openPublishModal])

useKeyPress(`${getKeyboardKeyCodeBySystem('ctrl')}.shift.p`, (e) => {
e.preventDefault()
if (publishDisabled || published)
return
onClickPublishBtn()
handlePublish()
}
, { exactMatch: true, useCapture: true })

Expand Down Expand Up @@ -217,7 +199,7 @@ const AppPublisher = ({
<Button
variant='primary'
className='w-full mt-3'
onClick={onClickPublishBtn}
onClick={() => handlePublish()}
disabled={publishDisabled || published}
>
{
Expand Down Expand Up @@ -314,13 +296,6 @@ const AppPublisher = ({
accessToken={accessToken}
/>
</PortalToFollowElem >
{publishModalOpen && (
<VersionInfoModal
isOpen={publishModalOpen}
onClose={closePublishModal}
onPublish={handlePublish}
/>
)}
</>
)
}
Expand Down
Loading