Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify OCI_ENDPOINT example value Fixes #15336 #15337

Merged
merged 2 commits into from
Mar 10, 2025

Conversation

engchina
Copy link
Contributor

@engchina engchina commented Mar 10, 2025

Summary

The example of oci_endpoint value format is wrong

in docker/.env.example:
OCI_ENDPOINT=https://objectstorage.us-ashburn-1.oraclecloud.com/

in docker/docker-compose.yaml:
OCI_ENDPOINT: ${OCI_ENDPOINT:-https://objectstorage.us-ashburn-1.oraclecloud.com}/

Right format is: https://{object-storage-namespace}.compat.objectstorage.{region}.oraclecloud.com

refer to: https://docs.public.oneportal.content.oci.oraclecloud.com/en-us/iaas/Content/Object/Tasks/s3compatibleapi.htm

Fix #15336

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Mar 10, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 10, 2025
@crazywoola crazywoola merged commit 20cbebe into langgenius:main Mar 10, 2025
8 checks passed
@engchina engchina deleted the modify_oci_endpoint branch March 10, 2025 05:37
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
AnyaParry pushed a commit to AnyaParry/dify that referenced this pull request Mar 17, 2025
modify OCI_ENDPOINT example value Fixes langgenius#15336 (langgenius#15337)

See merge request weihe/dify!5
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

oracle oci object storage oci_endpoint value format is wrong
2 participants