Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

downgrade boto3 to use s3 compatible storage. Fixes #15225 #15261

Merged
merged 1 commit into from
Mar 10, 2025

Conversation

engchina
Copy link
Contributor

@engchina engchina commented Mar 8, 2025

Summary

Downgrade boto3 from boto3==1.37.1 to boto3==1.35.99, Fixes #15225
and downgrade botocore==1.35.99, s3transfer==0.10.4 accordingly.

This link is description of the issue of boto3: boto/boto3#4398

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Mar 8, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 9, 2025
@crazywoola crazywoola merged commit 2968482 into langgenius:main Mar 10, 2025
8 checks passed
@engchina engchina deleted the downgrade_boto3 branch March 10, 2025 02:00
@laipz8200
Copy link
Member

laipz8200 commented Mar 11, 2025

This PR broke the s3 storage because the old version doesn't have the request_checksum_calculation parameter.

@laipz8200
Copy link
Member

refer #13354

@laipz8200 laipz8200 mentioned this pull request Mar 11, 2025
7 tasks
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

botocore.exceptions.ClientError: The Content-Length header is required
3 participants