Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: tool icons are missing #15241

Merged
merged 1 commit into from
Mar 8, 2025
Merged

fix: tool icons are missing #15241

merged 1 commit into from
Mar 8, 2025

Conversation

crazywoola
Copy link
Member

@crazywoola crazywoola commented Mar 7, 2025 •
edited
Loading

Summary

Update the nginx configuration file to avoid these errors. Thanks to @zhangxl01

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@crazywoola crazywoola linked an issue Mar 7, 2025 that may be closed by this pull request
When deploying dify locally, the tool icon cannot be displayed in workflow and agent. The solution is to modify the local nginx configuration to achieve it. #15189
Closed
5 tasks
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Mar 7, 2025
@crazywoola crazywoola requested a review from Yeuoly March 7, 2025 12:55
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 8, 2025
@crazywoola crazywoola merged commit 908a7b6 into main Mar 8, 2025
12 checks passed
@crazywoola crazywoola deleted the fix/15189-when-deploying-dify-locally-the-tool-icon-cannot-be-displayed-in-workflow-and-agent-the-solution-is-to-modify-the-local-nginx-configuration-to-achieve-it branch March 8, 2025 03:04
@kurokobo kurokobo mentioned this pull request Mar 8, 2025
Merged
5 tasks
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
@crazywoola @jackzhuo
fix: tool icons are missing (langgenius#15241)
eafbb94
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
@crazywoola @parambharat
fix: tool icons are missing (langgenius#15241)
b0ea1f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laipz8200 laipz8200 laipz8200 approved these changes

@Yeuoly Yeuoly Awaiting requested review from Yeuoly

Assignees
No one assigned
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@crazywoola @laipz8200