Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modify oracle lexer name Fixes #15106 #15108

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

engchina
Copy link
Contributor

@engchina engchina commented Mar 6, 2025

Summary

Change default oracle lexer from "CHINESE_VGRAM_LEXER" to "WORLD_LEXER".
Change default name form "multilingual_lexer" to "world_lexer" to avoid confusing.
Cause there are WORLD_LEXER and MULTI_LEXER, compared them, I think WORLD_LEXER is better than MULTI_LEXER.

Oralce docs about WORLD_LEXER and MULTI_LEXER for reference.

WORLD_LEXER:
https://docs.oracle.com/en/database/oracle/oracle-database/21/ccref/oracle-text-indexing-elements.html#GUID-FA7DB079-3247-49DB-A9F9-067F6281F879

MULTI_LEXER:
https://docs.oracle.com/en/database/oracle/oracle-database/21/ccref/oracle-text-indexing-elements.html#GUID-93B17833-A046-468C-BE5F-2BD09A61935C

Fixes #15106

Checklist

Important

Please review the checklist below before submitting your pull request.

  • [] This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation labels Mar 6, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 6, 2025
@crazywoola crazywoola merged commit 9c1db7d into langgenius:main Mar 6, 2025
8 checks passed
@engchina engchina deleted the modify_oracle_lexer_name branch March 6, 2025 13:11
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

modify oracle lexer name
2 participants