-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(llm/nodes.py): Ensure that the output returns without any exceptions #14880
Conversation
I have a question, why the source code pulls the outside of the exception catch? I'm not sure if I'm missing any designs |
Can this change fix #14876? It seems that unless the issue occurs at
there should be no difference between the two. |
This is the previous error stack message: |
If "outputs" dict is expected to be returned with a normal response, would it be more appropriate to put it in the try struct? |
The root issue is that a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Using a workflow for tool encapsulation, when core/workflow/nodes/llm/node.py LLMNode._run is called before the result_text is initialized, it causes the last output dict to reference an uninitialized variable
I directly appended the correct output to the result of the LLM output to ensure that there were no exceptions in the preceding process.
Tip
Close issue syntax:
Fixes #<issue number>
orResolves #<issue number>
, see documentation for more details.Fixes #14876
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods