Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support oracle oci autonomouse database. Fixes #14792 and Fixes #14628. #14804

Merged
merged 11 commits into from
Mar 4, 2025
Merged

feat: support oracle oci autonomouse database. Fixes #14792 and Fixes #14628. #14804

merged 11 commits into from
Mar 4, 2025

Conversation

engchina
Copy link
Contributor

@engchina engchina commented Mar 3, 2025

Summary

  1. Add support for oracle oci autonomouse database. Currently, dify only supports installed base oracle database. Fixes Support oracle autonomous database as vectorstore #14792 14792
  2. Rename lexer from "sys.my_chinese_vgram_lexer" to "multilingual_lexer" of user, cause in oracle oci autonomouse database, not sys user, only admin user of a pluggable database. Fixes DRG-10700: preference does not exist: sys.my_chinese_vgram_lexer #14628 14628

Checklist

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 📚 documentation Improvements or additions to documentation 📚 feat:datasource Data sources like web, Notion, Logseq, Lark, Docs labels Mar 3, 2025
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Mar 3, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Mar 3, 2025
crazywoola
crazywoola approved these changes Mar 4, 2025
View reviewed changes
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 4, 2025
@crazywoola crazywoola merged commit c8de30f into langgenius:main Mar 4, 2025
8 checks passed
@engchina engchina deleted the support-oci-adb branch March 4, 2025 01:49
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
@engchina @jackzhuo
feat: support oracle oci autonomouse database. Fixes langgenius#14792 …
3ff65f5 
…and Fixes langgenius#14628. (langgenius#14804)

Co-authored-by: engchina <[email protected]>
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
@engchina @parambharat
feat: support oracle oci autonomouse database. Fixes langgenius#14792 …
d09584a 
…and Fixes langgenius#14628. (langgenius#14804)

Co-authored-by: engchina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation 📚 feat:datasource Data sources like web, Notion, Logseq, Lark, Docs lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
2 participants
@engchina @crazywoola