Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace old-style <br> tags to fix Mermaid rendering issues #13792

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

haocheng6
Copy link
Contributor

@haocheng6 haocheng6 commented Feb 17, 2025

Summary

Fixes #13481 to ensure Mermaid renders correctly when the code contains <br> tags. The Mermaid Live Editor also does the same thing to ensure the exported SVG file is valid (see here).

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After Mermaid Code
rendered-flowchart-before rendered-flowchart-after See Code 1 below
rendered-flowchart-with-newline-before rendered-flowchart-with-newline-after See Code 2 below

Code 1

graph TD
    A[Start<br>Initialization] --> B{Condition?};
    B -- Yes --> C[Process A<br>Update Value];
    B -- No --> D[Process B<br>Skip Step];
    C --> E[End];
    D --> E;

Code 2

flowchart TD
    A[Christmas] -->|Get money| B(Go shopping)
    B --> C{Let me
 think}
    C -->|One| D[Laptop]
    C -->|Two| E[iPhone]
    C -->|Three| F[fa:fa-car Car]

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 🐞 bug Something isn't working labels Feb 17, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Mar 11, 2025
@crazywoola crazywoola merged commit 49d0acd into langgenius:main Mar 11, 2025
5 checks passed
@haocheng6 haocheng6 deleted the fix/13481-mermaid-br-tag branch March 16, 2025 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mermaid rendering error due to line break(both "<br>" and "\n") in node content.
2 participants