Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: new upgrade page #12417

Merged
merged 24 commits into from
Mar 6, 2025
Merged

Fix: new upgrade page #12417

merged 24 commits into from
Mar 6, 2025

Conversation

douxc
Copy link
Collaborator

@douxc douxc commented Jan 7, 2025 •
edited
Loading

Summary

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After

|
image
|image |

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@douxc douxc marked this pull request as ready for review January 13, 2025 05:38
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. 📚 documentation Improvements or additions to documentation labels Jan 13, 2025
GarfieldDai
GarfieldDai approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GarfieldDai
GarfieldDai approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@douxc douxc requested a review from GarfieldDai January 13, 2025 06:57
GarfieldDai
GarfieldDai previously approved these changes Jan 13, 2025
View reviewed changes
Copy link
Collaborator

@GarfieldDai GarfieldDai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

iamjoel
iamjoel previously approved these changes Jan 13, 2025
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jan 13, 2025
@douxc douxc marked this pull request as draft January 13, 2025 07:06
@douxc douxc dismissed stale reviews from iamjoel and GarfieldDai via 49415e5 January 14, 2025 08:38
@douxc douxc marked this pull request as ready for review March 5, 2025 09:39
@douxc douxc merged commit 9962118 into main Mar 6, 2025
9 checks passed
@douxc douxc deleted the fix/adjust-price-frontend branch March 6, 2025 02:27
jackzhuo pushed a commit to jackzhuo/dify that referenced this pull request Mar 14, 2025
@douxc @jackzhuo
Fix: new upgrade page (langgenius#12417)
de79634
parambharat pushed a commit to parambharat/dify that referenced this pull request Mar 31, 2025
@douxc @parambharat
Fix: new upgrade page (langgenius#12417)
5c4c5d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JzoNgKVO JzoNgKVO JzoNgKVO approved these changes

@iamjoel iamjoel iamjoel left review comments

@GarfieldDai GarfieldDai GarfieldDai left review comments

Assignees
No one assigned
Labels
📚 documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer size:XL This PR changes 500-999 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@douxc @iamjoel @JzoNgKVO @GarfieldDai