Skip to content

Fix code scanning alert no. 111: Incomplete URL substring sanitization #12305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 2, 2025
Merged

Fix code scanning alert no. 111: Incomplete URL substring sanitization #12305

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8779dc0
Fix code scanning alert no. 111: Incomplete URL substring sanitization
laipz8200 Jan 2, 2025
55d09a2
chore: code format
laipz8200 Jan 2, 2025
bd750cd
refactor: remove outdated comment on URL handling in AppDslService
laipz8200 Jan 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions api/services/app_dsl_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import uuid
from enum import StrEnum
from typing import Optional, cast
from urllib.parse import urlparse
from uuid import uuid4

import yaml # type: ignore
Expand Down Expand Up @@ -113,8 +114,12 @@ def import_app(
)
try:
max_size = 10 * 1024 * 1024 # 10MB
# tricky way to handle url from github to github raw url
if yaml_url.startswith("https://github.com") and yaml_url.endswith((".yml", ".yaml")):
parsed_url = urlparse(yaml_url)
if (
parsed_url.scheme == "https"
and parsed_url.netloc == "github.com"
and parsed_url.path.endswith((".yml", ".yaml"))
):
yaml_url = yaml_url.replace("https://github.com", "https://raw.githubusercontent.com")
yaml_url = yaml_url.replace("/blob/", "/")
response = ssrf_proxy.get(yaml_url.strip(), follow_redirects=True, timeout=(10, 10))
Expand Down
Loading