Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable all chunks status when disable document #12149

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

JohnJyong
Copy link
Collaborator

Summary

disable all chunks status when disable document

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

Before After
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label Dec 27, 2024
Copy link
Contributor

@bowenliang123 bowenliang123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whether we could update the segements by using document_id field as the filter in one update DML?
I suspect adding all the update DML of each segement will cause performance issue and super big transaction.

@JohnJyong
Copy link
Collaborator Author

Whether we could update the segements by using document_id field as the filter in one update DML? I suspect adding all the update DML of each segement will cause performance issue and super big transaction.

good suggestion

@JohnJyong JohnJyong merged commit 5a3fe61 into main Dec 27, 2024
8 checks passed
@JohnJyong JohnJyong deleted the fix/disable-document-segment branch December 27, 2024 09:08
laipz8200 added a commit that referenced this pull request Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants