Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Support Multi-Version Workflows #11990

Merged
merged 32 commits into from
Dec 27, 2024
Merged

Conversation

warren830
Copy link
Contributor

@warren830 warren830 commented Dec 23, 2024

Summary

Close #8484

It was implemented in #8484 by @luckylhb90 .

Screenshots

also showed author info

image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. labels Dec 23, 2024
@crazywoola crazywoola requested a review from laipz8200 December 23, 2024 07:26
@crazywoola
Copy link
Member

Please fix the lint errors.

@crazywoola
Copy link
Member

Link #10404

# Conflicts:
#	api/controllers/console/app/workflow.py
@dosubot dosubot bot removed the size:L This PR changes 100-499 lines, ignoring generated files. label Dec 26, 2024
@dosubot dosubot bot added the size:XXL This PR changes 1000+ lines, ignoring generated files. label Dec 26, 2024
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XXL This PR changes 1000+ lines, ignoring generated files. labels Dec 26, 2024
@warren830 warren830 requested a review from laipz8200 December 26, 2024 08:00
crazywoola
crazywoola previously approved these changes Dec 27, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 27, 2024
@dosubot dosubot bot removed the lgtm This PR has been approved by a maintainer label Dec 27, 2024
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve for back-end

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 27, 2024
Copy link
Member

@crazywoola crazywoola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazywoola crazywoola merged commit 901028f into langgenius:main Dec 27, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants