Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tool constant params change cause page crashed #11682

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

iamjoel
Copy link
Collaborator

@iamjoel iamjoel commented Dec 16, 2024

Summary

Fix:

  1. Tool constant params change cause page crashed.
  2. Tool constant params set to variable would be overwrited by number.

fixes: #11656

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@iamjoel iamjoel requested a review from zxhlyh December 16, 2024 06:21
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🐞 bug Something isn't working labels Dec 16, 2024
@iamjoel iamjoel marked this pull request as draft December 16, 2024 06:25
@iamjoel iamjoel marked this pull request as ready for review December 16, 2024 06:32
@dosubot dosubot bot added the ☕️ typescript Pull request that update TypeScript code. label Dec 16, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 16, 2024
@iamjoel iamjoel merged commit 607a22a into main Dec 16, 2024
7 checks passed
@iamjoel iamjoel deleted the fix/tool-constant-change-page-crash branch December 16, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the BraveSearch tool, entering "Result count" causes an error.
2 participants