fix: change http node params from dict to list tuple #11665

hjlarry · 2024-12-15T02:23:22Z

Summary

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

fix #11660
also fix the key of param can't extract vaiable pool's value

Before	After
...	...

Important

Please review the checklist below before submitting your pull request.

This change requires a documentation update, included: Dify Document
I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
I've updated the documentation accordingly.
I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

laipz8200

LGTM

fix a http node params issue

Loading
Loading status checks…

d29afd4

dosubot bot added size:M 🐞 bug size:L and removed size:M labels Dec 15, 2024

fix unit tests

Loading
Loading status checks…

967de1f

hjlarry changed the title ~~fix: a http node params issue~~ fix: change http node params from dict to list tuple Dec 15, 2024

hjlarry added 2 commits December 15, 2024 13:58

param's value should allow \n

05a52eb

fix CI

b6d1f56

crazywoola requested a review from laipz8200 December 15, 2024 09:06

laipz8200 approved these changes Dec 15, 2024

View reviewed changes

dosubot bot added the lgtm label Dec 15, 2024

laipz8200 merged commit 9c7a1bc into langgenius:main Dec 15, 2024
5 checks passed

iamjoel pushed a commit that referenced this pull request Dec 16, 2024

fix: change http node params from dict to list tuple (#11665)

66d7d7a