Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add elkjs #11404

Merged
merged 1 commit into from
Dec 6, 2024
Merged

fix: add elkjs #11404

merged 1 commit into from
Dec 6, 2024

Conversation

kurokobo
Copy link
Contributor

@kurokobo kurokobo commented Dec 5, 2024

Summary

Add elkjs for web container.

The changes in this PR made by:

$ cd dify
$ docker run --rm -it -v ${PWD}:/dify --entrypoint sh node:20-alpine3.20
/ # apk add git
/ # cd /dify/web
/dify/web # yarn add elkjs

I confirmed that the build was successful and that the Dify Web UI can be opened normally.

Closes #11400

Screenshots

N/A

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. dependencies Pull requests that update a dependency file labels Dec 5, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 6, 2024
@crazywoola crazywoola merged commit 9a0dc4b into langgenius:main Dec 6, 2024
4 checks passed
@kurokobo kurokobo deleted the yarn branch December 6, 2024 03:23
iamjoel pushed a commit that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The web container cannot be built due to #11356.
2 participants