-
Notifications
You must be signed in to change notification settings - Fork 13.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'Open in Explore' link for each apps on studio #11402
Conversation
00e8d2e
to
87c45fa
Compare
87c45fa
to
2ebb085
Compare
6bf9fb5
to
dedbcba
Compare
I have updated the PR and marked it as Ready for Review. When "Open in Explore" is clicked, it fetches I also considered fetching the list of all Installed Apps when opening the Studio to find the corresponding ID, but since the creation of the Installed App is executed asynchronously and triggered by events, it seems that we cannot guarantee the existence of the Installed App immediately after it is created. Therefore, I implemented this to fetch the ID when clicking the menu instead. I would appreciate your review. Thanks in advance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @kurokobo! Thank you for your contribution! It would be great if you could add a new get method in the InstalledAppApi and pass the app ID in the URL path, rather than using the InstalledAppsListApi. Would you mind making this improvement in a separate PR? 😊 |
@laipz8200 I’m thinking about working on improvements to the API, but I’d like your opinion on the design of the endpoints. Assumptions:
Required endpoints to enable
Questions about your suggestions:
Please share your thoughts, thanks! |
@kurokobo |
Summary
This PR adds an "Open in Explore" link to the menu of each app in the app list in Studio, and the menu under
Publish
button in Studio.Clicking this link will open the target app in Explore in a new tab.
Also, to prevent the items in the pop-up menu from containing line break, I will slightly widen its width.
To achieve this, following changes are made by this PR:
/console/api/installed-apps
to allow querying installed apps byapp_id
Open in Explore
menu for each apps in the app list on studioCloses #11401
Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods