Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dialogue_count incorrect in chatflow when there's... #11175

Merged
merged 2 commits into from
Dec 2, 2024

Conversation

xuzuodong
Copy link
Contributor

@xuzuodong xuzuodong commented Nov 27, 2024

...regenerated message.

Summary

In the Chatflow App, the dialogue_count system variable becomes inaccurate when messages are regenerated. This variable is stored in the conversations table of the database and is incremented each time a message is sent. However, with the introduction of the message regeneration feature, this method is no longer suitable for cases involving regenerated messages.

This PR changes the calculation method for the dialogue_count system variable. It now dynamically calculates the value based on the thread messages of the conversation.

Screenshots

Before: After:
2024-11-27.23.01.33.mov
2024-11-27.22.58.59.mov

Caveats

The dialogue_count column in the conversation table should no longer be necessary. However, this pull request does not include a migration script to remove this column.

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. 🐞 bug Something isn't working labels Nov 27, 2024
@laipz8200 laipz8200 self-requested a review November 27, 2024 15:14
@laipz8200 laipz8200 self-assigned this Nov 27, 2024
laipz8200
laipz8200 previously approved these changes Dec 1, 2024
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Dec 1, 2024
@crazywoola crazywoola merged commit c4fad66 into langgenius:main Dec 2, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants