fix: dialogue_count
incorrect in chatflow when there's...
#11175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...regenerated message.
Summary
In the Chatflow App, the
dialogue_count
system variable becomes inaccurate when messages are regenerated. This variable is stored in theconversations
table of the database and is incremented each time a message is sent. However, with the introduction of themessage regeneration
feature, this method is no longer suitable for cases involving regenerated messages.This PR changes the calculation method for the
dialogue_count
system variable. It now dynamically calculates the value based on the thread messages of the conversation.Screenshots
2024-11-27.23.01.33.mov
2024-11-27.22.58.59.mov
Caveats
The
dialogue_count
column in theconversation
table should no longer be necessary. However, this pull request does not include a migration script to remove this column.Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat
(backend) andcd web && npx lint-staged
(frontend) to appease the lint gods