Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/add admin check #11050

Merged
merged 3 commits into from
Nov 25, 2024
Merged

Feat/add admin check #11050

merged 3 commits into from
Nov 25, 2024

Conversation

KMerdan
Copy link
Contributor

@KMerdan KMerdan commented Nov 25, 2024

Summary

This PR introduces a new is_admin property in the Account model and the corresponding utility method is_admin_role in the TenantAccountRole class. These changes enhance access control and ensure only administrators can manage critical application settings if required.

Key Changes:

  • Added is_admin property to the Account model to simplify admin checks.

  • Added is_admin_role static method to TenantAccountRole to encapsulate role-specific logic.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@KMerdan KMerdan marked this pull request as ready for review November 25, 2024 02:32
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. 💪 enhancement New feature or request labels Nov 25, 2024
@KMerdan KMerdan marked this pull request as draft November 25, 2024 02:43
@KMerdan KMerdan marked this pull request as ready for review November 25, 2024 03:03
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 25, 2024
@laipz8200 laipz8200 merged commit 41772c3 into main Nov 25, 2024
8 checks passed
@laipz8200 laipz8200 deleted the feat/add-admin-check branch November 25, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants