Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gpt-4o-audio-preview): Remove the vision feature #10932

Merged

Conversation

laipz8200
Copy link
Member

@laipz8200 laipz8200 commented Nov 21, 2024

Summary

This LLM is not support vision now.

Screenshots

Before: After:
... ...

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 21, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@crazywoola crazywoola merged commit 82575a7 into main Nov 21, 2024
14 checks passed
@crazywoola crazywoola deleted the fix/remove-vision-feature-from-gpt-4o-audio-preview branch November 21, 2024 08:42
@fdb02983rhy
Copy link
Contributor

Hi there, please consider reverting this fix before there is an option for other file types. There are not way to send request to the model with audio file after this fix. Or you can simply rename the "Vision" to "File" Since we have #10679 and #10966. Not sure if it's a good option tho.

Before

Pasted Graphic 1

After

Pasted Graphic

@laipz8200
Copy link
Member Author

Hi @fdb02983rhy! Please check #10679, you can use file variables in prompt editor directly now.

@fdb02983rhy
Copy link
Contributor

Hi @fdb02983rhy! Please check #10679, you can use file variables in prompt editor directly now.

It works!! Thank you so much:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants