Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update parse.py to handle empty list result #10915

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Update parse.py to handle empty list result #10915

merged 2 commits into from
Nov 21, 2024

Conversation

PedroGomes02
Copy link
Contributor

Summary

Improve Built-in Tool JSON Process - Improve "Parse" _extract function to handle empty list result after applying json_filter.

Resolves #10914

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Nov 20, 2024
@crazywoola crazywoola requested a review from laipz8200 November 21, 2024 00:59
laipz8200
laipz8200 previously approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@laipz8200 laipz8200 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 21, 2024
@laipz8200
Copy link
Member

Please run dev/reformat to appease the lint gods

@crazywoola crazywoola merged commit 83b6abf into langgenius:main Nov 21, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crazywoola crazywoola crazywoola approved these changes

@laipz8200 laipz8200 laipz8200 left review comments

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Built-in Tool JSON Process - Improve "Parse" _extract function #10913
3 participants
@PedroGomes02 @laipz8200 @crazywoola