Fix : Add a process to fetch the mime type from the file name for signed url in remote_url #10872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not being retrieved by dify in remote_url. '
dosubot
bot
added
size:XS
crazywoola
approved these changes
Nov 20, 2024
laipz8200
reviewed
Nov 20, 2024
| @@ -169,6 +169,7 @@ def _get_remote_file_info(url: str): | |||
| mime_type = mimetypes.guess_type(url)[0] or "" | |||
| file_size = -1 | |||
| filename = url.split("/")[-1].split("?")[0] or "unknown_file" | |||
| mime_type = mime_type or mimetypes.guess_type(filename)[0] | |||
There was a problem hiding this comment.
I think we can use this way directly and remove L169, would you mind making this change?
There was a problem hiding this comment.
I agree. I will create a new pull request.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a process to fetch the mime type from the file name for signed url in remote_url
Summary
Fixes #10737
Fix the issue that the remote_url encounters an error due to the inability to retrieve the mime type when using an S3 signed URL.
Add a process to fetch the mime type from the file name. This method is already implemented in api/controllers/common/helpers.py.
Add the following line to line 172 of api/factories/file_factory.py:
"mime_type = mime_type or mimetypes.guess_type(filename)[0]".
Confirmed that the MIME type is correctly retrieved in the local environment.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Tip
Close issue syntax:
Fixes #<issue number>orResolves #<issue number>, see documentation for more details.Screenshots
Checklist
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint gods