Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a minimal separator between pinned apps and unpinned apps in the explore page #10871

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

kurokobo
Copy link
Contributor

Summary

This PR adds a minimal separator between Pinned Apps and Unpinned Apps in the Explore page. The separator is displayed only if there are both pinned apps and unpinned apps.

Tested as follows:

  • Pin one or more apps and then ensure the separator is displayed
  • Unpin all apps and then ensure the separator is not displayed
  • Pill all apps and then ensure the separator is not displayed

Fixes #10869

Tip

Close issue syntax: Fixes #<issue number> or Resolves #<issue number>, see documentation for more details.

Screenshots

There are 5 pinned apps on the top.

Before After
image image

Checklist

Important

Please review the checklist below before submitting your pull request.

  • This change requires a documentation update, included: Dify Document
  • I understand that this PR may be closed in case there was no previous discussion or issues. (This doesn't apply to typos!)
  • I've added a test for each change that was introduced, and I tried as much as possible to make a single atomic change.
  • I've updated the documentation accordingly.
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 💪 enhancement New feature or request labels Nov 19, 2024
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Nov 20, 2024
@crazywoola crazywoola merged commit 07b5bba into langgenius:main Nov 20, 2024
4 checks passed
@kurokobo kurokobo deleted the explore_div branch November 20, 2024 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a minimal separator between Pinned Apps and Unpinned Apps in the Explore page
2 participants