refactor(workflow): introduce specific exceptions for code validation #10218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created custom exception classes for code node validation errors. - Replaced generic `ValueError` with more descriptive `OutputValidationError` and `DepthLimitError`. - Improved error handling and clarity in the code node execution process.
dosubot
bot
added
size:M
15 tasks
crazywoola
approved these changes
Nov 4, 2024
crazywoola
deleted the
refactor/introduce-specific-exceptions-for-code-validation
branch
Nov1c444
pushed a commit
that referenced
this pull request
Nov 5, 2024
Yeuoly
pushed a commit
that referenced
this pull request
Nov 5, 2024
iamjoel
pushed a commit
that referenced
this pull request
Nov 7, 2024
AlwaysBluer
pushed a commit
to AlwaysBluer/dify
that referenced
this pull request
Nov 14, 2024
idonotknow
pushed a commit
to AceDataCloud/Dify
that referenced
this pull request
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Important
Please review the checklist below before submitting your pull request.
dev/reformat(backend) andcd web && npx lint-staged(frontend) to appease the lint godsDescription
ValueErrorwith more descriptiveOutputValidationErrorandDepthLimitError.Type of Change
Testing Instructions
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration